Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize decision on culling #45

Closed
rccern opened this issue Mar 4, 2022 · 3 comments
Closed

Customize decision on culling #45

rccern opened this issue Mar 4, 2022 · 3 comments
Labels
duplicate This issue or pull request already exists

Comments

@rccern
Copy link

rccern commented Mar 4, 2022

Proposed change

In our Jupyterhub deployment we have the possibility of assigning users to nodes with GPU, which are a "scarce" resource. For this reason, we would like to have different timeouts depending on which resources the users have booked, e.g. letting sessions expire after 2h since last_activity for nodes with GPUs and 6h for nodes using only CPU.

Alternative options

Implement this in another culler that we keep for our deployment

Who would use this feature?

Admins who desire to customize the culler behaviour. Use cases include reserving resources for shorter periods of time for some type of resources, a longer period for users with a specific role...

(Optional): Suggest a solution

I was thinking about customizing the should_cull https://github.com/jupyterhub/jupyterhub-idle-culler/blob/main/jupyterhub_idle_culler/__init__.py#L238 with a configurable callable which takes as inputs the user and the server objects and returns a boolean. Does it make any sense?

@rccern rccern added the enhancement New feature or request label Mar 4, 2022
@welcome
Copy link

welcome bot commented Mar 4, 2022

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@rccern
Copy link
Author

rccern commented Mar 4, 2022

I noticed only after publishing that this is essentially a duplicate of #25 , let me know if you prefer that I close this one and continue the discussion there

@manics manics added duplicate This issue or pull request already exists and removed enhancement New feature or request labels Mar 4, 2022
@manics
Copy link
Member

manics commented Mar 4, 2022

#25 or one of the issues linked there is definitely the best place. Would you mind copying your use case there? Thanks!

@manics manics closed this as completed Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants