You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sometimes we disable the hub-managed cull-idle service in our deployment during high load events and run the script manually with just a timeout, i.e. --cull-every is the default of 0.
Alternative is just killing the script when you think it's done, but without more verbose logging to know when each IOLoop is complete that might be hard to know, especially if the culler is running slowly.
Who would use this feature?
Anyone running the culler manually.
(Optional): Suggest a solution
If we don't want to change the behavior of --cull-every=0 then maybe a simple option is supporting --cull-every=-1 to mean exit immediately when done, don't run the IOLoop.
The text was updated successfully, but these errors were encountered:
Proposed change
Currently the script runs until it encounters a keyboard interrupt:
https://github.com/jupyterhub/jupyterhub-idle-culler/blob/v1.0/jupyterhub_idle_culler/__init__.py#L436
Sometimes we disable the hub-managed
cull-idle
service in our deployment during high load events and run the script manually with just a timeout, i.e.--cull-every
is the default of 0.It would be nice if there was a way to just run the script and let it exit rather than run the IOLoop, especially since there isn't any logging around https://github.com/jupyterhub/jupyterhub-idle-culler/blob/v1.0/jupyterhub_idle_culler/__init__.py#L341 so if that list is empty (there are no users) it appears to just hang and you might not be sure what it's doing.
Alternative options
Alternative is just killing the script when you think it's done, but without more verbose logging to know when each IOLoop is complete that might be hard to know, especially if the culler is running slowly.
Who would use this feature?
Anyone running the culler manually.
(Optional): Suggest a solution
If we don't want to change the behavior of
--cull-every=0
then maybe a simple option is supporting--cull-every=-1
to mean exit immediately when done, don't run the IOLoop.The text was updated successfully, but these errors were encountered: