Skip to content

Commit 7c57f40

Browse files
committed
Add ability to set annotations + labels for proxy-public service
We should eventually allow setting labels and annotations on all the objects we create. For now, proxy-public is most useful, especially on AWS. Fixes #37
1 parent 51cd7cf commit 7c57f40

File tree

3 files changed

+6
-0
lines changed

3 files changed

+6
-0
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ installation.
5757
* Support using a static PVC for user homes or for the hub db. This makes this release usable
5858
with clusters where you only have one NFS share that must be used for the whole hub.
5959
* PostgreSQL is now a supported hub database backend provider.
60+
* You can set annotations & labels on the proxy-public service now.
6061
6162
### Other Changes ###
6263

jupyterhub/templates/proxy/service.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@ apiVersion: v1
1414
kind: Service
1515
metadata:
1616
name: proxy-public
17+
# toYaml + indent seem a lot more unstable & error prone
18+
annotations: {{ toJson .Values.proxy.service.annotations }}
19+
labels: {{ toJson .Values.proxy.service.labels }}
1720
spec:
1821
type: {{ .Values.proxy.service.type }}
1922
{{ if .Values.proxy.service.loadBalancerIP -}}

jupyterhub/values.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ proxy:
2828
secretToken: 'generate with openssl rand -hex 64'
2929
service:
3030
type: LoadBalancer
31+
labels: {}
32+
annotations: {}
3133
image:
3234
name: jupyterhub/configurable-http-proxy
3335
tag: 2.0.1

0 commit comments

Comments
 (0)