From dc43320ba140054391a491186227455ea6fcab49 Mon Sep 17 00:00:00 2001
From: YuviPanda <yuvipanda@gmail.com>
Date: Fri, 19 Jul 2024 09:55:08 -0700
Subject: [PATCH] Remove always failing linter

This was introduced in https://github.com/jupyterhub/grafana-dashboards/pull/106,
and has never passed. I don't think we should have a test that is always
expected to fail.

If it should be re-introduced, it should be done in such a way that
whatever changes are needed to make it pass should be part of the PR.

This only reverts the linter, but keeps the rendering test - as that would
help us catch possible jsonnet syntax issues.
---
 .github/workflows/test.yaml | 39 +------------------------------------
 1 file changed, 1 insertion(+), 38 deletions(-)

diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
index cbb4cc0..06e7f44 100644
--- a/.github/workflows/test.yaml
+++ b/.github/workflows/test.yaml
@@ -21,7 +21,7 @@ on:
   workflow_dispatch:
 
 jobs:
-  render-lint-dashboards:
+  render-dashboards:
     runs-on: ubuntu-22.04
 
     strategy:
@@ -48,40 +48,3 @@ jobs:
           do
               jsonnet -J vendor --output-file rendered-dashboards/`basename $file` $file
           done
-
-      - name: Install dashboard-linter
-        run: |
-          go install github.com/grafana/dashboard-linter@latest
-          echo "$HOME/go/bin" >> "$GITHUB_PATH"
-
-      - name: dashboard-linter rules
-        run: |
-          echo "Available rules are documented in https://github.com/grafana/dashboard-linter/blob/main/docs/index.md#rules"
-          echo ""
-          dashboard-linter rules
-
-      - name: dashboard-linter lint
-        run: |
-          lint_failures=""
-
-          dashboard_folders=rendered-dashboards
-          for file in `find $dashboard_folders -name '*.jsonnet'`
-          do
-              lint_fail=""
-              echo "::group::$file"
-              dashboard-linter lint --strict $file || lint_fail=1
-              echo "::endgroup::"
-              if [ -n "$lint_fail" ]; then
-                  lint_failures="$lint_failures $file";
-              fi
-          done
-
-          if [ -n "$lint_failures" ]; then
-              echo ""
-              echo "dashboard-linter errored for:"
-              for file in $lint_failures
-              do
-                  echo `basename $file`
-              done
-              exit 1
-          fi