Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take no action if already authenticated? #66

Open
cboettig opened this issue Aug 20, 2024 · 0 comments
Open

Take no action if already authenticated? #66

cboettig opened this issue Aug 20, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@cboettig
Copy link

Proposed change

Currently consecutive runs create a fresh token each time regardless of whether a valid token is already available. While this may be necessary in some cases, this behavior can be confusing especially to newcomers.

Who would use this feature?

This could be particularly useful to students, but could also pave the way for tighter integration with other applications -- e.g. it would be possible for a Git interface (like maybe the one built into JupyterLab?!) to automatically call gh-scoped-creds and have it prompt for login if and only if that login were actually needed.

(Optional): Suggest a solution

I think it would be better if the application were able to first perform a test to see if a valid (non-expired) token already existed, and only initiate the request for a new token if the current token has expired or none is found. Ideally an optional argument like --force could force renewal (the current behavior).

@cboettig cboettig added the enhancement New feature or request label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant