Should k8s-binder-k8s-hub/binderhub-chart-config-old.yaml be kept or deleted?

[manics]

k8s-binder-k8s-hub/binderhub-chart-config-old.yaml says it should be deleted:

binderhub/testing/k8s-binder-k8s-hub/binderhub-chart-config-old.yaml

Lines 1 to 2 in 7fa1d77

	# (DELETE ME)
	# this file should be removed immediately after merging PR #1472

However it's referenced in the CI workflows:

binderhub/.github/workflows/diff.yml

Lines 54 to 59 in 7fa1d77

	old_config="../testing/k8s-binder-k8s-hub/binderhub-chart-config-old.yaml"
	if [ -f "$old_config" ]; then
	echo "using old config"
	else
	old_config="../testing/k8s-binder-k8s-hub/binderhub-chart-config.yaml"
	fi

binderhub/.github/workflows/test.yml

Lines 185 to 190 in 7fa1d77

	old_config="../testing/k8s-binder-k8s-hub/binderhub-chart-config-old.yaml"
	if [ -f "$old_config" ]; then
	echo "using old config"
	else
	old_config="../testing/k8s-binder-k8s-hub/binderhub-chart-config.yaml"
	fi

Should it be kept and the comment removed, or should the file and all references to it be deleted?

[consideRatio]

• support extraFiles for binderhub pod #1472 is merged at this point. I presume we should remove all references to it.

I recognize the need for having two sets of helm chart configuration because the CI system tests against an old version and then upgrades to a new version etc. I presume this is about that, and that we can now remove everything related to it.

@minrk you added the DELETE ME note, do you agree on deleting the file and all logic referencing it?