Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for GitLab push in project registry #1336

Open
sgaist opened this issue Jul 14, 2021 · 1 comment
Open

Support for GitLab push in project registry #1336

sgaist opened this issue Jul 14, 2021 · 1 comment

Comments

@sgaist
Copy link
Contributor

sgaist commented Jul 14, 2021

Proposed change

Forges like GitLab allows to have a per-project registry. However the current implementation fixes the prefix used to push images to one defined project.
This implies that there must be one dedicated project that will store all the images.
This also means that when the service is behind authentication, every user shall have access to that repo and thus all images can be viewed by every users. There are use cases where this is not desired.

There's work currently done in #1154 and #1169 to support user specific private repository access/build with GitLab but there's nothing available for pushing back to the corresponding repositories.

The feature requested is to add the possibility to configure BinderHub so that it pushes the generated images back to the registry from the project the image was built from.

Alternative options

To the best of my knowledge there's currently no alternative.

Who would use this feature?

  • People wanting to keep the image close to the repository that generated them
  • People wanting to give access to the image only to the members of a project

(Optional): Suggest a solution

As far as I know, there's no direct way to do it. The image_prefix is currently used as is.

One possible way to do it would be to delegate the tag/image name creation to the RepoProvider with a default implementation that does what is currently done.
Then in the GitLabRepoProvider, have an additional boolean property that would allow to use the default implementation or generate the image name based on the provided repo with a minimal prefix like for example "binder-".

@welcome
Copy link

welcome bot commented Jul 14, 2021

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant