From 2cf677212e032f9ce5daaaefb57c4817826d1804 Mon Sep 17 00:00:00 2001 From: Raniere Silva Date: Tue, 14 Jan 2025 15:41:11 +0100 Subject: [PATCH 1/2] Add Python build step to documentation Closes https://github.com/jupyterhub/binderhub/issues/1910 --- docs/source/contribute.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/source/contribute.md b/docs/source/contribute.md index 9d9f53363..1191673db 100644 --- a/docs/source/contribute.md +++ b/docs/source/contribute.md @@ -200,7 +200,7 @@ continue. values to reference these images. ```bash - (cd helm-chart && chartpress) + (python3 -m build . && cd helm-chart && chartpress) ``` 4. Get the chart dependencies (for example JupyterHub) From 43ab94afeee5d8de6504e8645e7a213f28b47f27 Mon Sep 17 00:00:00 2001 From: Raniere Silva Date: Tue, 14 Jan 2025 15:42:04 +0100 Subject: [PATCH 2/2] Add command for users using Docker Desktop --- docs/source/contribute.md | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/docs/source/contribute.md b/docs/source/contribute.md index 1191673db..7717b7529 100644 --- a/docs/source/contribute.md +++ b/docs/source/contribute.md @@ -137,13 +137,19 @@ continue. ``` 1. Configure `docker` using environment variables to use the same Docker daemon - as your `minikube` cluster. This means images you build are directly - available to the cluster. + as your local Kubernetes cluster. This means images you build are directly + available to the cluster. If using `minikube`, ```bash eval $(minikube docker-env) ``` + If using Docker Desktop, + + ```bash + docker context use desktop-linux + ``` + 1. Start BinderHub with the testing config file. ```bash @@ -189,13 +195,19 @@ continue. ``` 2. Configure `docker` using environment variables to use the same Docker daemon - as your `minikube` cluster. This means images you build are directly - available to the cluster. + as your local Kubernetes cluster. This means images you build are directly + available to the cluster. If using `minikube`, ```bash eval $(minikube docker-env) ``` + If using Docker Desktop, + + ```bash + docker context use desktop-linux + ``` + 3. Build the docker images referenced by the Helm chart and update its default values to reference these images.