From b251afac59c81da0601ea0235fa78f7032c5e1fa Mon Sep 17 00:00:00 2001 From: Min RK Date: Mon, 25 Apr 2022 12:56:59 +0200 Subject: [PATCH] disable schema validation when installing for a different version config is for the new version, don't validate it against the old schema, otherwise PRs updating the schema will always fail CI --- .github/workflows/diff.yml | 2 ++ .github/workflows/test.yml | 1 + 2 files changed, 3 insertions(+) diff --git a/.github/workflows/diff.yml b/.github/workflows/diff.yml index 0b1a60c126..9975e90316 100644 --- a/.github/workflows/diff.yml +++ b/.github/workflows/diff.yml @@ -37,11 +37,13 @@ jobs: # NOTE: We change the directory so binderhub the chart name won't be # misunderstood as the local folder name. + # validation is disabled, because the config is for a different version! cd testing helm install binderhub-test binderhub \ --values ./k8s-binder-k8s-hub/binderhub-chart-config.yaml \ --repo https://jupyterhub.github.io/helm-chart/ \ + --disable-openapi-validation \ --version=$UPGRADE_FROM_VERSION - name: "Helm diff latest released dev chart with local chart" diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index b606d51007..d55fc1374c 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -169,6 +169,7 @@ jobs: cd ci helm install binderhub-test \ --repo https://jupyterhub.github.io/helm-chart/ binderhub \ + --disable-openapi-validation \ --version=$UPGRADE_FROM_VERSION \ --values ../testing/k8s-binder-k8s-hub/binderhub-chart-config.yaml \ --set config.BinderHub.hub_url=http://localhost:30902 \