Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test matrix #248

Open
ryanlovett opened this issue Aug 25, 2022 · 2 comments
Open

Update test matrix #248

ryanlovett opened this issue Aug 25, 2022 · 2 comments

Comments

@ryanlovett
Copy link
Contributor

Proposed change

Update text matrix to be more inline with jupyterhub and in-use distributions.

#247 was failing in python 3.5 but not 3.9. I saw that 3.5 had not been supported in JupyterHub for a while so asked whether 3.5 could be dropped. @mbmilligan said:

So yes, I think I'm okay with dropping testing support for Python 3.5. I wouldn't drop 3.6 support for a while yet though. As that's currently the newest Python that can easily be installed on those CentOS 7 systems, I think we're stuck with it until those systems go EOL in 2024.

This suggests changing the oldest version batchspawner supports from 3.5 to 3.6.

Alternative options

Do nothing, and ensure future PRs are compatible with python 3.5 too.

Who would use this feature?

Contributors who don't want to support older pythons.

(Optional): Suggest a solution

Should the matrix be expanded to support everything JupyterHub does, plus 3.6? That is, batchspawner's tests are on 3.5 and 3.9 right now, so should the set be 3.6 and 3.9, or 3.6 .. 3.11 ?

@welcome
Copy link

welcome bot commented Aug 25, 2022

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@willfurnass
Copy link
Contributor

NB folks still on EL7 can get Python 3.8 from the rh-python3.8 RedHat Software Collection (more info).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants