Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance optimization, allow for "init" and "await" mode #33

Open
consideRatio opened this issue Oct 3, 2021 · 2 comments
Open

Performance optimization, allow for "init" and "await" mode #33

consideRatio opened this issue Oct 3, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@consideRatio
Copy link
Member

Currently this action installs and awaits readiness. But, it could be useful to install, do something else, then await readiness.

I suggest we could allow this action to be called either normally, but also in "init" or "await" mode where the normal mode is equal to "init" + "await". By doing that, one could run other things in between.

@consideRatio consideRatio added the enhancement New feature or request label Oct 3, 2021
@manics
Copy link
Member

manics commented Oct 4, 2021

Is it worth spliting it into two actions instead?

@consideRatio
Copy link
Member Author

consideRatio commented Oct 4, 2021

Is it worth spliting it into two actions instead?

Oh nooo I absolutely don't think that, I'd rather not do this at all if it would come to that.

EDIT: I just wanted to clarify, I feel that it's a quite fancy feature that one can live without, but one that could reduce test times with some tens of seconds perhaps which can be nice for some setups to make use of. I think the complexity introduced could be quite low in this action, even though notable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants