Stabilize cell height when scrolling #17132
Draft
+175
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Code changes
Adds
cellHeightStabilization
andassumeHeightStabilityAfter
options:cellHeightStabilization
: Whether to pin height of the cells when scrolling to stabilize viewport (prevent jitter), and for how long since the last scroll event (in milliseconds).assumeHeightStabilityAfter
: If cell height stabilization is enabled, how many milliseconds should pass since the last height measurement for the stabilization algorithm to be allowed to pin the cell heightTo be done:
widgetSizes
exposure/_getCellIndex
method)assumeHeightStabilityAfter
be 5 seconds favouring some widgets rendering for up to seconds and less frequent output "unroll" animation, or should it be 1 second favouring more stability when scrolling but less frequent "unroll" animations?cellHeightStabilization
be? Ideally it is as large as to catch consecutive scroll events (i.e. >= interval between mouse scroll wheel steps, or mouse movements when using scrollbar), and as small as to minimise the time before the outputs are "unrolled" after the scroll stopped.User-facing changes
Scrolling is no longer jittery.
Backwards-incompatible changes
None