Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow interacted lagged controls in panel and not checking rows #8

Merged
merged 4 commits into from
Apr 26, 2024

Conversation

junyuan-chen
Copy link
Owner

@junyuan-chen junyuan-chen commented Apr 24, 2024

When data do not contain any invalid rows, it's now possible to skip the checks by specifying checkrows=false with lp.

A new keyword argument wgnames for lp helps specifying lagged control variables that are interacted with panelid. Estimation does not involve building full data columns for these interacted variables, although results are numerically identical.

Fixed issues that caused wrong residuals when panelweight is specified and estimation involves 2SLS.

@junyuan-chen junyuan-chen added enhancement New feature or request breaking Breaking changes are involved labels Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (abe2506) to head (07a8a43).

Additional details and impacted files
@@            Coverage Diff             @@
##              main        #8    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            7         7            
  Lines         1206      1439   +233     
==========================================
+ Hits          1206      1439   +233     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@junyuan-chen junyuan-chen added the bug Something isn't working label Apr 26, 2024
@junyuan-chen junyuan-chen merged commit 33d865c into main Apr 26, 2024
9 checks passed
@junyuan-chen junyuan-chen deleted the pr/LPData branch April 26, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes are involved bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant