Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Needless component creation in EntityEdit#add(Component) #661

Open
navneetankur opened this issue Jul 13, 2023 · 0 comments
Open
Labels

Comments

@navneetankur
Copy link

EntityEdit#add(Component) first creates a component using reflection and then replaces it with the component provided in argument. Why not just use the argument component directly.

It needlessly creates an extra component to be garbage collected as well as time taken to create that component using reflection. Seems like a simple fix.
Am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant