Skip to content

Commit d47ed57

Browse files
committed
fix: drop trt level from setup.sql, clarify further that the ERD is partial
1 parent 3202174 commit d47ed57

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

metadata/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ erDiagram
8383

8484
### Schema Notes
8585

86-
- This diagram shows simplified table structures. See `db/setup.sql` for complete column definitions and documentation.
86+
- **Simplified Overview:** This diagram shows key columns only (e.g., COMPOUND has additional Metadata_InChI column). See `db/setup.sql` for complete definitions.
8787
- The `PERTURBATION` table is created during database setup by combining all compound, ORF, and CRISPR IDs (no separate CSV file).
8888
- `PERTURBATION_CONTROL` defines which perturbations are controls (negcon/poscon/empty) and provides human-readable names (e.g., "DMSO" → JCP2022_033924). Note: The ORF table also has a legacy `Metadata_pert_type` column, but PERTURBATION_CONTROL is now the canonical source for all control designations across compound, ORF, and CRISPR modalities.
8989

metadata/db/setup.sql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,14 +167,14 @@ COMMENT ON COLUMN perturbation.Metadata_perturbation_modality IS 'Type of pertur
167167
-- Control designation table (provides human-readable names and control types)
168168
CREATE TABLE perturbation_control (
169169
Metadata_JCP2022 VARCHAR PRIMARY KEY,
170-
Metadata_pert_type VARCHAR CHECK (Metadata_pert_type IN ('trt', 'poscon', 'negcon', 'empty')),
170+
Metadata_pert_type VARCHAR CHECK (Metadata_pert_type IN ('poscon', 'negcon', 'empty')),
171171
Metadata_Name VARCHAR,
172172
FOREIGN KEY (Metadata_JCP2022) REFERENCES perturbation(Metadata_JCP2022)
173173
);
174174

175175
COMMENT ON TABLE perturbation_control IS 'Control type and human-readable names for special perturbations. Note: The orf table already contains a Metadata_pert_type column which is redundant with this table and may be deprecated in future versions';
176176
COMMENT ON COLUMN perturbation_control.Metadata_JCP2022 IS 'JUMP Perturbation ID';
177-
COMMENT ON COLUMN perturbation_control.Metadata_pert_type IS 'Perturbation type: trt (treatment), poscon (positive control), negcon (negative control), empty (empty well)';
177+
COMMENT ON COLUMN perturbation_control.Metadata_pert_type IS 'Perturbation type: poscon (positive control), negcon (negative control), empty (empty well)';
178178
COMMENT ON COLUMN perturbation_control.Metadata_Name IS 'Human-readable name for the perturbation (e.g., "DMSO" instead of "JCP2022_033924"). This column provides friendly names for commonly used controls and does not map to any existing table columns';
179179

180180
-- Core experimental tables (depend on microscope_config and cellprofiler_version)

0 commit comments

Comments
 (0)