Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop target column in metadata to avoid confusion? #93

Open
shntnu opened this issue Nov 18, 2024 · 3 comments
Open

Drop target column in metadata to avoid confusion? #93

shntnu opened this issue Nov 18, 2024 · 3 comments

Comments

@shntnu
Copy link
Contributor

shntnu commented Nov 18, 2024

@niranjchandrasekaran Ok to drop the target column in https://github.com/jump-cellpainting/2024_Chandrasekaran_NatureMethods/blob/0d64eabc8ca665b2c75a49a03bcdbd97924b1385/metadata/external_metadata/JUMP-Target-1_compound_metadata_targets.tsv?

That has caused confusion in the past; IIUC we only used target_list in all the results presented in the final version of the paper.

@niranjchandrasekaran
Copy link
Contributor

IIUC we only used target_list in all the results presented in the final version of the paper.

That's correct.

I wouldn't drop the target column. But I am ok renaming it because this is the column that determined which genes were chosen for the genetic perturbation experiments, and it would be good to have a record of that.

@shntnu
Copy link
Contributor Author

shntnu commented Nov 20, 2024

Ah got it. I did replace it in https://github.com/jump-cellpainting/JUMP-Target/pull/36/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5; I'm guessing that's ok? (because it matters for the paper repo)

@niranjchandrasekaran
Copy link
Contributor

niranjchandrasekaran commented Nov 20, 2024

I'm guessing that's ok? (because it matters for the paper repo)

I guess that's fine. The original files are still in jump-cellpainting/jump-cellpainting (internal link) so we can always find the target column there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants