Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes an issue on MacOS Big Sur 11.6 (#288) #289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnlee999
Copy link

After upgrading MacOS to 11.6, terminal-notifier shows another notification with a message "terminal" when you click the original notification. (see issue #288 )
It seems that terminal-notifier can't receive any message by notification center from 11.6.
So it makes 'userNotification' always null.

Thus, this never runs.

 if (userNotification) {
    [self userActivatedNotification:userNotification];

Terminal-notifier quits after it delivered a notification.
But if terminal-notifier is still alive after the notification, it can receive the message.
So I tried to make it keep alive as a daemon.

I'm not sure yet if there's the side effects of allowing it to be resident, but it can now opens url I gave by clicking the notification.

@synconclick
Copy link

Hello, can you please provide the steps on how you kept Terminal-notifier alive as a daemon? Thanks

@johnlee999
Copy link
Author

@synconclick
Hi.
Basically, it's controlled by isDaemon flag. Could you check the diff of my commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants