Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

going form 3.5.0 to 3.6.0 breaks http CORS requests and --mock #137

Open
naugtur opened this issue Mar 24, 2017 · 3 comments
Open

going form 3.5.0 to 3.6.0 breaks http CORS requests and --mock #137

naugtur opened this issue Mar 24, 2017 · 3 comments

Comments

@naugtur
Copy link
Contributor

naugtur commented Mar 24, 2017

I didn't find out what's happening yet, but I saw a lot of tests failing
naugtur/xhr#156

I can reproduce running ok on 3.5.0 and breaking on 3.6.0

[edits]

  • also with latest
  • works fine in other browsers, it's about electron

Will report more as I go.

Any known issues?

@naugtur naugtur closed this as completed Mar 24, 2017
@naugtur naugtur reopened this Mar 24, 2017
@naugtur
Copy link
Contributor Author

naugtur commented Mar 24, 2017

After digging in electron, I'm back here.

099da66#diff-8e402bf78d4c5f8a4fb797709e5bc7a3L12

window.location is set to file:// protocol now, so:

  • mock option is now cross-domain
  • window.origin is null and correct CORS requests are not possible.

This is a big breaking change for my case.

@naugtur naugtur changed the title going form 3.5.0 to 3.6.0 breaks http requests going form 3.5.0 to 3.6.0 breaks http CORS requests and --mock Mar 24, 2017
@TehShrike
Copy link

Probable duplicate of #135

@naugtur
Copy link
Contributor Author

naugtur commented Apr 12, 2017

Protocol is fixed and things got better, but there's still something wrong.
xhr tests work in 3.5.0, fail miserably later, then 10 failures occur on 4.0.2
I'll be looking into why that is happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants