Skip to content
This repository has been archived by the owner on Nov 8, 2018. It is now read-only.

Unclear doc regarding out parameter path #176

Open
drahnr opened this issue Apr 30, 2018 · 2 comments
Open

Unclear doc regarding out parameter path #176

drahnr opened this issue Apr 30, 2018 · 2 comments

Comments

@drahnr
Copy link

drahnr commented Apr 30, 2018

I am not sure what this is supposed to be, so far I tried to equal it to the directory name of my task execution, hence dir: x would imply path: x:

path: Required. The path of the repository to reference the pull request.

resources:
- name: pr-firmware
  type: pull-request
  source:
    access_token: ((github-access-token))
    private_key: ((sshkey))
    repo: myorg/myrepo
    base: master
    uri: [email protected]:myorg/myrepo.git


jobs:
  - name: check-pr-firmware
    plan:
    - get: firmware
      resource: pr-firmware
      trigger: true

    - get: container-geared-up

    - task: firmware-builds-check
      image: container-geared-up
      config:
        platform: linux
        inputs:
        - name: firmware
        outputs:
        - name: binary
        run:
          path: zsh
          args:
          - -exec
          - |
            build.sh
          dir: firmware


      on_failure:
        put: pr-firmware // fails
        params:
          path: firmware
          status: failure
          context: compile-test

      on_success:
        put: pr-firmware
        params:
          path: firmware  // fails
          status: success
          context: compile-test

      on_failure:
        put: pr-firmware // fails
        params:
          path: pr-firmware
          status: failure
          context: compile-test

yet I am getting:

Identity added: /tmp/git-resource-private-key redactedcomment
	
/usr/lib/ruby/gems/2.4.0/gems/octokit-4.8.0/lib/octokit/response/raise_error.rb:16:in `on_complete': POST https://api.github.com/repos/myorg/myrepo/statuses/1a602acadff6f269bd964cfc1ea6bee10a6b3e3e: 404 - Not Found // See: https://developer.github.com/v3/repos/statuses/#create-a-status (Octokit::NotFound)
	
	from /usr/lib/ruby/gems/2.4.0/gems/faraday-0.14.0/lib/faraday/response.rb:9:in `block in call'
	
	from /usr/lib/ruby/gems/2.4.0/gems/faraday-0.14.0/lib/faraday/response.rb:61:in `on_complete'
	
	from /usr/lib/ruby/gems/2.4.0/gems/faraday-0.14.0/lib/faraday/response.rb:8:in `call'
	
	from /usr/lib/ruby/gems/2.4.0/gems/faraday-http-cache-2.0.0/lib/faraday/http_cache.rb:146:in `call!'
	
	from /usr/lib/ruby/gems/2.4.0/gems/faraday-http-cache-2.0.0/lib/faraday/http_cache.rb:115:in `call'
	
	from /usr/lib/ruby/gems/2.4.0/gems/faraday-0.14.0/lib/faraday/rack_builder.rb:143:in `build_response'
	
	from /usr/lib/ruby/gems/2.4.0/gems/faraday-0.14.0/lib/faraday/connection.rb:387:in `run_request'
	
	from /usr/lib/ruby/gems/2.4.0/gems/faraday-0.14.0/lib/faraday/connection.rb:175:in `post'
	
	from /usr/lib/ruby/gems/2.4.0/gems/sawyer-0.8.1/lib/sawyer/agent.rb:94:in `call'
	
	from /usr/lib/ruby/gems/2.4.0/gems/octokit-4.8.0/lib/octokit/connection.rb:156:in `request'
	
	from /usr/lib/ruby/gems/2.4.0/gems/octokit-4.8.0/lib/octokit/connection.rb:28:in `post'
	
	from /usr/lib/ruby/gems/2.4.0/gems/octokit-4.8.0/lib/octokit/client/statuses.rb:43:in `create_status'
	
	from /usr/lib/ruby/gems/2.4.0/gems/octokit-4.8.0/lib/octokit.rb:46:in `method_missing'
	
	from /opt/resource/lib/status.rb:15:in `create!'
	
	from /opt/resource/lib/commands/out.rb:59:in `block in output'
	
	from /opt/resource/lib/commands/out.rb:52:in `each'
	
	from /opt/resource/lib/commands/out.rb:52:in `output'
	
	from /opt/resource/lib/commands/out.rb:117:in `<main>'
@jtarchie
Copy link
Owner

jtarchie commented May 3, 2018

Is the repo something the access token has access to write to? It's pretty standard for the GitHub API to return 404 when you don't have access to do something. That way it doesn't expose data.

@drahnr
Copy link
Author

drahnr commented May 3, 2018

Seems my second comment got lost. It was exactly that. Still I wasn't aware of the issue and a hint by the resource would be appreciated.
If you differ, feel free to close this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants