Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins not included in lity.js file in the dist folder #267

Open
johnsfuller opened this issue Feb 3, 2021 · 1 comment
Open

Plugins not included in lity.js file in the dist folder #267

johnsfuller opened this issue Feb 3, 2021 · 1 comment

Comments

@johnsfuller
Copy link

Documentation says to

Include the Lity javascript and css files and its dependencies in your HTML document

It does not mention that the plugins have to be manually included.

A lot of YouTube issues stem from people not knowing to manually include their needed plugins (in their case the youtube.js plugin).

In the dist folder, I suggest either including the plugins in the dist/lity.js and dist/lity.min.js files or updating documentation so users know a build process is required.

@Kiseki
Copy link

Kiseki commented Feb 5, 2021

Thanks @johnsfuller, I wasn't sure why it didn't work until you pointed this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants