Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: Expected signal to be an instanceof AbortSignal #1399

Closed
anwbfvr opened this issue Feb 27, 2024 · 3 comments
Closed

TypeError: Expected signal to be an instanceof AbortSignal #1399

anwbfvr opened this issue Feb 27, 2024 · 3 comments

Comments

@anwbfvr
Copy link

anwbfvr commented Feb 27, 2024

We experience a bug in node-fetch in relation to minifying code: node-fetch/node-fetch#784 when using @jsforce/[email protected]

The bug is fixed in node-fetch@3 (according to node-fetch/node-fetch#784 (comment)), so updating the dependency of node-fetch might help.

@cristiand391
Copy link
Member

We explored the upgrade path from node-fetch v2 -> v3 for jsforce a few weeks ago and decided we'll stay on node-fetch v2 for jsforce v3.

I'll post the details later post GA, but a few things that blocks us from using node-fetch v3 are:

Also, now node has native a fetch we want to explore dropping node-fetch and just use the nativefetch in node and browsers (probably in the jsforce v4 roadmap).

@john-bflow-mcgowan
Copy link

@anwbfvr did any of the workarounds in the linked node-fetch issue resolve your issue? I'm also running into this issue deploying my code with jsforce 2.0.0

@anwbfvr
Copy link
Author

anwbfvr commented Apr 8, 2024

@anwbfvr did any of the workarounds in the linked node-fetch issue resolve your issue? I'm also running into this issue deploying my code with jsforce 2.0.0

Yes, we are now using https://esbuild.github.io/api/#keep-names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants