Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font flickering in the settings' tabs #24

Open
toby-bro opened this issue Sep 1, 2024 · 4 comments
Open

Font flickering in the settings' tabs #24

toby-bro opened this issue Sep 1, 2024 · 4 comments
Labels
bug Something isn't working help wanted Extra attention is needed priority: low

Comments

@toby-bro
Copy link
Contributor

toby-bro commented Sep 1, 2024

Describe the bug
In the Settings when changing menu a quick flickering and changing of the fonts happen

To Reproduce
Go to the settings and change tabs apps, launcher, meta, if you record your screen a slight flutter of the font happens

Expected behavior
No changing of the tabs fonts throughout the app navigation

Screenshots

Additional info
I tried debugging this issue, it does not seem to be a code issue as changing tabs does not call particular functions (if all the tabs are loaded in memory, (I tried caching all the tabs and putting breakpoints on all the functions).

I guess it's the system font that loads temporarily before hack is fully loaded but it is surprising.

The same behavior is seen when choosing an action.

Quite a lot of the code in settingsActivity.tk is deprecated but I'll try and update this in a future PR

Just upgrading did not solve the problem on my side

@toby-bro toby-bro added the bug Something isn't working label Sep 1, 2024
@toby-bro
Copy link
Contributor Author

toby-bro commented Sep 1, 2024

Screen_Recording_20240901_012130_Launcher.mp4

A video where the bug can be seen

@jrpie jrpie added the help wanted Extra attention is needed label Sep 11, 2024
@jrpie
Copy link
Owner

jrpie commented Sep 11, 2024

The font seems to reset to Roboto (when setting the font to system default globally, the flicker is gone).
Hardcoding Hack in the TabLayout directly doesn't seem to help.
It does not seem to be related to Hack as with other ttf fonts this happens as well.
Maybe this is a bug of the TabLayout?

@toby-bro
Copy link
Contributor Author

Indeed it could be.
Some such bugs were already mentionned in the past...
https://stackoverflow.com/questions/31828610/why-do-the-tablayouts-tabs-icons-texts-blink-when-swiping-between-pages#31937728
When will you be pushing a v0.0.10 ? And when for a v1.0.0 ? Soon, all the bugs are will be solved and the "final" match between app functionalities and app expectancies will be met.

@jrpie
Copy link
Owner

jrpie commented Sep 12, 2024

Some such bugs were already mentionned in the past...

Yes, I expect that this is something similar.

When will you be pushing a v0.0.10 ? And when for a v1.0.0 ? Soon, all the bugs are will be solved and the "final" match between app functionalities and app expectancies will be met.

Well, there are always more bugs than one would expect 😅 But maybe starting with 0.0.1 was a bit pessimistic.
I'm thinking about releasing 0.1.0 soon (basically after fixing the worst bugs that are currently open).
For 1.0 I'd also want to implement the favorite apps / hidden apps feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed priority: low
Projects
None yet
Development

No branches or pull requests

2 participants