Memory leak when parsing Array Initializers

[cwalter-at]

The function ParseArrayInitializer first estimates the number of elements by calling itself again with DoAssignment=False. The problem in line 285. The ExpressionParser allocates the value on the stack.

picoc/parse.c

Line 285 in a97d94f

if (!ExpressionParse(Parser, &CValue))

As DoAssignment is false line 288 is not true and the variable is never released anymore.

I think the following pop condition below shall be added.

if (Parser->Mode == RunModeRun && DoAssignment) { ExpressionAssign(Parser, ArrayElement, CValue, false, NULL, 0, false); VariableStackPop(Parser, CValue); VariableStackPop(Parser, ArrayElement); } else if(Parser->Mode == RunModeRun) { VariableStackPop(Parser, CValue); }