Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default timeout for running cell tests #211

Open
ceball opened this issue Nov 5, 2020 · 1 comment
Open

Increase default timeout for running cell tests #211

ceball opened this issue Nov 5, 2020 · 1 comment
Labels
lang: javascript PRs or issues related to Javascript

Comments

@ceball
Copy link
Collaborator

ceball commented Nov 5, 2020

Currently, once you click to run cell tests in jupyter lab, the result needs to come back within 5 seconds or it'll be cancelled.

But even if all heavy parts of a notebook are mocked out, many a notebook's celltests will not complete in 5 seconds.

We should probably up the default to 15 seconds or so.

import {IRequestResult, request} from "requests-helper";

request("post",

https://github.com/timkpaine/requests-helper/blob/master/src/index.ts#L21

That should be easy.

We could also consider making that configurable.

However, it might be better to focus on improving how celltests are launched: #210

@vidartf
Copy link
Collaborator

vidartf commented Nov 10, 2020

I think this is an artifact of the current UX. With a better UX, we could up the timeout a lot (and make it a setting), and instead ensure that the user is able to cancel the test run e.g. by pressing a button.

@timkpaine timkpaine added lang: javascript PRs or issues related to Javascript and removed jupyterlab_celltests labels Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang: javascript PRs or issues related to Javascript
Projects
None yet
Development

No branches or pull requests

3 participants