-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase default timeout for running cell tests #211
Labels
lang: javascript
PRs or issues related to Javascript
Comments
I think this is an artifact of the current UX. With a better UX, we could up the timeout a lot (and make it a setting), and instead ensure that the user is able to cancel the test run e.g. by pressing a button. |
timkpaine
added
lang: javascript
PRs or issues related to Javascript
and removed
jupyterlab_celltests
labels
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, once you click to run cell tests in jupyter lab, the result needs to come back within 5 seconds or it'll be cancelled.
But even if all heavy parts of a notebook are mocked out, many a notebook's celltests will not complete in 5 seconds.
We should probably up the default to 15 seconds or so.
nbcelltests/js/src/run.ts
Line 15 in fa86221
nbcelltests/js/src/run.ts
Line 35 in fa86221
https://github.com/timkpaine/requests-helper/blob/master/src/index.ts#L21
That should be easy.
We could also consider making that configurable.
However, it might be better to focus on improving how celltests are launched: #210
The text was updated successfully, but these errors were encountered: