-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Measure actual coverage, not "cell coverage" #156
Comments
@vidartf is this something you can help with? I see you've done it for nbval computationalmodelling/nbval#134 since we have the |
@timkpaine The nbval coverage is all about getting coverage data in python modules, from the execution of the notebook. It doesn't currently attempt to measure coverage in the notebook. The problem is that coverage will not be available in the same scope as the coverage gathering was started, i.e. the notebook global scope. There might be a clever work-around somehow, but I haven't dived deep enough into it to find anything. |
Current cell coverage
(num cells tested)/(num cells)
is a proxy for actual coverage.nbval includes a coverage measure - should investigate that.
Current coverage is relatively easy to fake, e.g.
Something related to "what actually ran?" (e.g. detection that cell source was submitted to kernel) might be better than a static check.
The text was updated successfully, but these errors were encountered: