Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge jpmondet/vrnetlab to upstream #1

Open
danoost opened this issue Mar 25, 2021 · 2 comments
Open

Merge jpmondet/vrnetlab to upstream #1

danoost opened this issue Mar 25, 2021 · 2 comments

Comments

@danoost
Copy link

danoost commented Mar 25, 2021

Hey there, I've just got this working well against v9.3(7), and I was wondering if there were any plans to merge your changes at jpmondet/vrnetlab to plajjan/vrnetlab. I see there's an open issue at upstream for n9kv support that also hasn't been touched for a while. Would you be open to me linking your fork to them?

I also wonder what the licensing situation for the bios.bin included here is. Where did you obtain it? Is it potentially an issue for the merging process?

@danoost
Copy link
Author

danoost commented Mar 26, 2021

I posted on a pull request over at upstream with the results of my findings, to bring this issue full circle. I'll leave it open until there's some kind of resolution on the linked PR :)

@jpmondet
Copy link
Owner

jpmondet commented Mar 26, 2021

Hey @danoost !

Oh I had to cleanup a lil' bit and merge this last year but WFH suddenly stopped for me, loosing all the extra time I had for this in the process 😕

Thank you very much for having taken the time to bring this work upstream 🙂

And yeah, you pretty much found everything I found on this bios.bin thingy, you rock ! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants