Node selection capability #541
Merged
+70
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amisevsk I've added the required capabilites. |
* Check filters for validity before attempting to use * Accept filters that start with a '.' character (jq-style) * Check validity of field at each step, to avoid reflect-related panics * Minor refactoring to pull filtering into a separate function
amisevsk
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Sorry I missed reviewing this until now @srikary12 -- the PR looks good and is a great early implementation that we can improve going forward (accessing items in arrays would be particularly useful). It works well for basic usage.
I pushed a few minor fixes to this PR before merging:
- I pulled the filtering code to a separate function for clarity
- I added basic validation for the filter (to avoid filters like
model.ormod..elfrom crashing) - I switched the
isValid()check to happen in the loop, to avoid reflect panicking on inputs likemodel.testone.testtwo, wheretestoneleads to an invalid field - Finally, I made it handle filters that start with a dot (e.g.
.model) since that's what I'm used to from usingjq:)
Thanks again for the PR, this is great work 👍
|
These are my first few contributions in go lang, I'll keep track of these suggestions and try to get better. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds node selection capability for .kitfile.
Linked issues
Fixes #462