Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: dictionary changed size during iteration #507

Open
foarsitter opened this issue Feb 14, 2024 · 4 comments · May be fixed by #508
Open

Bug: dictionary changed size during iteration #507

foarsitter opened this issue Feb 14, 2024 · 4 comments · May be fixed by #508
Labels
bug Something isn't working

Comments

@foarsitter
Copy link

foarsitter commented Feb 14, 2024 •
edited

Somehow my models aren't completely loaded when the admin is initialized. During the setup of the admin fields are added to the model and therefore self.model.__dict__ changed size during iteration.

Fixing the problem is easier than isolating a test case, so I do not have something to reproduce the error.

  • Starlette-Admin version: 0.13.2
  • ORM/ODMs: SQLAlchemy
@foarsitter foarsitter added the bug Something isn't working label Feb 14, 2024
@foarsitter foarsitter linked a pull request Feb 14, 2024 that will close this issue
Open
@jowilf
Copy link
Owner

jowilf commented Feb 16, 2024

Without a minimal reproducible example, we can't ensure that PR #508 effectively fixed the issue.

@foarsitter
Copy link
Author

For now you have to believe me that this fixed my project :) For the foreseeable future I will update the PR but not in upcoming week.

@hasansezertasan
Copy link
Contributor

For now you have to believe me that this fixed my project :) For the foreseeable future I will update the PR but not in upcoming week.

I think you should provide an example use case.

@foarsitter
Copy link
Author

I'm unable to find the root cause and thus cannot provide a failing test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Get primary key fields from mapper foarsitter/starlette-admin
3 participants
@foarsitter @hasansezertasan @jowilf