Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Illegible diffs #311

Open
2 tasks done
xmready opened this issue Jul 28, 2022 · 1 comment
Open
2 tasks done

Illegible diffs #311

xmready opened this issue Jul 28, 2022 · 1 comment

Comments

@xmready
Copy link

xmready commented Jul 28, 2022

Terminal Emulator Info

GNOME Terminal 3.44.0 using VTE 0.68.0 +BIDI +GNUTLS +ICU +SYSTEMD

Output From vim --version

VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Apr 18 2022 19:26:30)
Included patches: 1-3995
Modified by [email protected]
Compiled by [email protected]
Huge version without GUI.

Issue Description

Hi! The current column and line for changes in a diff is illegible with set cursorcolumn and set cursorline. Here is what it looks like with onedark:
image

Here is what it looks like with everforest:
image

You can see the difference in legibility for the column and line the cursor is on; onedark makes them unreadable and almost black. If this isn't something you are willing to change, which highlight group would I have to mess with in order to fix it? Un-setting the set cursorcolumn and set cursorline fixes it, but I like these options set.

Also, I would like to put in my vote to have the underlining on changed lines replaced with a darker shade of background color, which would still offer the ability to tell which parts of the line have actually changed. Here is an example of what that looks like in other themes:
image

Thank you for onedark Josh, I really do love it.

@CoelacanthusHex
Copy link

Same problem here, Arch Linux with vim 9.0.0158 and konsole 22.04.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants