Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling pause while track is loading has no effect. #114

Open
curiousdustin opened this issue Apr 29, 2020 · 0 comments · May be fixed by #115
Open

Calling pause while track is loading has no effect. #114

curiousdustin opened this issue Apr 29, 2020 · 0 comments · May be fixed by #115

Comments

@curiousdustin
Copy link

Describe the bug
If pause() is called while the next track is loading, the track still plays after it has loaded.

Expected behavior
The track would not play once it has loaded. Instead it would be paused at the beginning.

Desktop (please complete the following information):

  • Version 0.11.2

Additional context
I believe this is because of the _playWhenReady flag. If I add the following in AVPlayerWrapper, the issue is resolved.

func pause() {
    _playWhenReady = false
    avPlayer.pause()
}
@curiousdustin curiousdustin linked a pull request Apr 29, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant