Skip to content
This repository has been archived by the owner on May 26, 2020. It is now read-only.

IE11 has problems with JS #565

Open
kasvith opened this issue Jun 20, 2018 · 7 comments
Open

IE11 has problems with JS #565

kasvith opened this issue Jun 20, 2018 · 7 comments
Assignees
Milestone

Comments

@kasvith
Copy link
Contributor

kasvith commented Jun 20, 2018

Steps to reproduce the issue

  • Just open the NMM in IE11

Expected result

  • A working NMM

Actual result

  • A broken NMM

System information (as much as possible)

  • Windows 10
  • IE 11

Additional comments

These are the errors possibly shown in the console of IE11 with stack

image

  • Object doesn't support property or method 'startsWith'

"TypeError: Object doesn't support property or method 'startsWith'
at Anonymous function (http://localhost/media-manager-improvement/media/com_media/js/mediamanager.min.js:6:73955)
at Anonymous function (http://localhost/media-manager-improvement/media/com_media/js/mediamanager.min.js:6:73926)
at e.default.methods.findDrive (http://localhost/media-manager-improvement/media/com_media/js/mediamanager.min.js:6:73875)
at e.default.computed.crumbs (http://localhost/media-manager-improvement/media/com_media/js/mediamanager.min.js:6:73513)
at ba.prototype.get (http://localhost/media-manager-improvement/media/com_media/js/mediamanager.min.js:6:5648)
at ba.prototype.evaluate (http://localhost/media-manager-improvement/media/com_media/js/mediamanager.min.js:6:6638)
at Anonymous function (http://localhost/media-manager-improvement/media/com_media/js/mediamanager.min.js:1:19440)
at t.exports.render (http://localhost/media-manager-improvement/media/com_media/js/mediamanager.min.js:6:74113)
at t.p"

  • 'Promise' is undefined

"ReferenceError: 'Promise' is undefined
at Anonymous function (http://localhost/media-manager-improvement/media/com_media/js/mediamanager.min.js:6:114084)
at T.prototype.dispatch (http://localhost/media-manager-improvement/media/com_media/js/mediamanager.min.js:11:3396)
at dispatch (http://localhost/media-manager-improvement/media/com_media/js/mediamanager.min.js:11:2716)
at e.default.mounted (http://localhost/media-manager-improvement/media/com_media/js/mediamanager.min.js:6:56232)
at jt (http://localhost/media-manager-improvement/media/com_media/js/mediamanager.min.js:1:17430)
at wa.insert (http://localhost/media-manager-improvement/media/com_media/js/mediamanager.min.js:6:7449)
at S (http://localhost/media-manager-improvement/media/com_media/js/mediamanager.min.js:6:20092)
at Anonymous function (http://localhost/media-manager-improvement/media/com_media/js/mediamanager.min.js:6:21570)
at t.prototype._update (http://localhost/media-manager-improvement/media/com_media/js/mediamanager"

  • Object doesn't support property or method 'find'

"TypeError: Object doesn't support property or method 'find'
at i (http://localhost/media-manager-improvement/media/com_media/js/mediamanager.min.js:11:14767)
at Anonymous function (http://localhost/media-manager-improvement/media/com_media/js/mediamanager.min.js:11:15480)
at Anonymous function (http://localhost/media-manager-improvement/media/com_media/js/mediamanager.min.js:11:15446)
at Anonymous function (http://localhost/media-manager-improvement/media/com_media/js/mediamanager.min.js:6:113857)
at Anonymous function (http://localhost/media-manager-improvement/media/com_media/js/mediamanager.min.js:11:3204)
at Anonymous function (http://localhost/media-manager-improvement/media/com_media/js/mediamanager.min.js:11:3182)
at T.prototype._withCommit (http://localhost/media-manager-improvement/media/com_media/js/mediamanager.min.js:11:4447)
at T.prototype.commit (http://localhost/media-manager-improvement/media/com_media/js/mediamanager.min.js:11:3154)
at commit (http://localhost/media"

@laoneo
Copy link
Contributor

laoneo commented Jun 20, 2018

Is the promise issue because of #561?

@schnuti
Copy link
Collaborator

schnuti commented Jun 20, 2018

A promise is used in 561 because this is what upload is using. In both cases callbacks would do if you do not chain the promises anyway.

@kasvith
Copy link
Contributor Author

kasvith commented Jun 21, 2018

I think promise issue is from upstream. files are retrieving with promises

@schnuti
Copy link
Collaborator

schnuti commented Jun 21, 2018

Sorry for not reporting the problem before. I thought it was known. IE 11 never accepted to start the new MM. i.e. it's not a new issue.

screenshot_1

@kasvith
Copy link
Contributor Author

kasvith commented Jun 21, 2018

yes, its not from your code

@dgrammatiko
Copy link
Contributor

@kasvith since I don't have a VM with IE11 atm, can you do a simple test for me?
open https://github.com/joomla-projects/media-manager-improvement/blob/dev/media/vendor/webcomponentsjs/js/webcomponents-sd-ce-pf.min.js

remove all contents and paste the contents from https://github.com/webcomponents/webcomponentsjs/blob/master/webcomponents-bundle.js

check that promises and all the other missing polyfills are loaded.

If so I will make the needed changes

@kasvith
Copy link
Contributor Author

kasvith commented Jul 12, 2018

@dgrammatiko tried pasting the above file and i still gets the same issue

@laoneo laoneo added this to the Stabilize milestone Jul 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants