Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot Dismiss Ad Blocker Message #27

Open
sdwjoomla opened this issue May 16, 2023 · 6 comments
Open

Cannot Dismiss Ad Blocker Message #27

sdwjoomla opened this issue May 16, 2023 · 6 comments
Labels
Needs Retesting An older issue that we think is fixed but needs retesting

Comments

@sdwjoomla
Copy link

Environment:
Joomla! 4.3.1
PHP 8.0.23, 8.1.6 and 8.2.0
JVP setup from Readme

Goal: Silence/Close/Dismiss the ad blocker message

Outcome:
Clicked the 'x' to the left of the message. Nothing happened.
image
@mfleeson
Copy link
Collaborator

Where is this ad blocker code from? I've never seen this in core Joomla.

@mfleeson
Copy link
Collaborator

@sdwjoomla Please can you test this with the new installation. I think the Joomla template was getting confused. The new template 4.0.3 should fix this.

@sdwjoomla
Copy link
Author

@mfleeson I will test it later today

@mfleeson
Copy link
Collaborator

Suggest you hold off. Found an issue in the template 4 file not using web assets. Think that will fix this issue but I've not committed it yet.

@mfleeson
Copy link
Collaborator

The checker is part of the jdotorg template.

@sdwjoomla
Copy link
Author

Oh! Just let me know when to try again.

@mfleeson mfleeson added the Needs Retesting An older issue that we think is fixed but needs retesting label Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs Retesting An older issue that we think is fixed but needs retesting
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mfleeson @sdwjoomla