-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple arguments overwrites values in arguments #18
Comments
I found that also doing a Object.assign({}, o1) before piping into assignDeep didn't help, so maybe I'm in the wrong here. It's a "WAT" moment for me at least :) |
This looks like a bug to me. The code in this area should probably change, but I don't know off the top of my head what is necessary. I'm not sure when I'll get a chance to look more closely, but PRs are welcome :) |
same problem here, this didn't happen with version 0.4.8 or before. |
This looks similar to this issue of a related project. I haven't tested it, but I guess, it can be fixed by changing the mentioned line Line 28 in ee7ca64
target[key] = assignSymbols({}, args[i][key]); in case |
Using Object.assign with an empty target, only the target is changed, not the inputs/arguments. Usign assign-deep, the inputs also get overwritten. Is this expected behaviour? I did not expect this.
The text was updated successfully, but these errors were encountered: