Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assertion failure for it_should_return_user_search_results_list_when_matches_found test method #688

Closed
heapallocation opened this issue May 12, 2024 · 1 comment · Fixed by #700
Assignees
Labels
tests Relates to Apex or LWC jest tests Type: Bug Something isn't working

Comments

@heapallocation
Copy link

Package Edition of Nebula Logger

Unlocked Package

Package Version of Nebula Logger

v4.12.9

New Bug Summary

Hi there,

I have installed the unlocked pkg in a sandbox and am attempting to deploy via the metadata api. Upon deploying I get an assertion failure in the it_should_return_user_search_results_list_when_matches_found method of the LoggerEngineDataSelector_Tests.cls.

It is the second assertion: System.Assert.areEqual(expectedResultsById.size(), result.size()); the reason it fails is that the LogManagementDataSelector.getUsersByNameSearch soql query has a limit of 20, this invariable makes the expectedResultsById different to the users returned from the org for the results.size.

I have fixed the issue for myself, but just thought I'd raise an issue to let you guys know.

Cheers!
John.

@heapallocation heapallocation added the Type: Bug Something isn't working label May 12, 2024
@jongpie
Copy link
Owner

jongpie commented May 20, 2024

@heapallocation thanks for reporting this - this should hopefully be an easy fix. I'll try to get this resolved in the next few weeks/wherever I'm able to release a new version.

@jongpie jongpie added the tests Relates to Apex or LWC jest tests label May 20, 2024
@jongpie jongpie self-assigned this May 20, 2024
jongpie added a commit that referenced this issue Jun 18, 2024
…gementDataSelector.getInstance().getUsersByNameSearch(), instead of duplicating the query
jongpie added a commit that referenced this issue Jun 18, 2024
…gementDataSelector.getInstance().getUsersByNameSearch(), instead of duplicating the query
jongpie added a commit that referenced this issue Jul 9, 2024
…gementDataSelector.getInstance().getUsersByNameSearch(), instead of duplicating the query
jongpie added a commit that referenced this issue Jul 10, 2024
…gementDataSelector.getInstance().getUsersByNameSearch(), instead of duplicating the query
jongpie added a commit that referenced this issue Jul 12, 2024
…gementDataSelector.getInstance().getUsersByNameSearch(), instead of duplicating the query
jongpie added a commit that referenced this issue Jul 14, 2024
…gementDataSelector.getInstance().getUsersByNameSearch(), instead of duplicating the query
jongpie added a commit that referenced this issue Jul 16, 2024
…gementDataSelector.getInstance().getUsersByNameSearch(), instead of duplicating the query
jongpie added a commit that referenced this issue Aug 6, 2024
…gementDataSelector.getInstance().getUsersByNameSearch(), instead of duplicating the query
jongpie added a commit that referenced this issue Aug 8, 2024
…gementDataSelector.getInstance().getUsersByNameSearch(), instead of duplicating the query
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Relates to Apex or LWC jest tests Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants