Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New LoggerAdmin queue as fallback record owner #560

Closed
wants to merge 8 commits into from
Closed

New LoggerAdmin queue as fallback record owner #560

wants to merge 8 commits into from

Conversation

jongpie
Copy link
Owner

@jongpie jongpie commented Sep 28, 2023 •
edited
Loading

@jongpie
Created new queue LoggerAdmin, with a configurable LoggerParameter__m…
5139b1d 
…dt record, FallbackRecordOwnerQueue, to specify a different queue name
@jongpie
Updated LogEntryEventHandler to use the LoggerAdmin queue when a more…
15b2a23 
… fitting owner cannot be determined for new records in LoggerScenario__c, Log__c, and LoggerTag__c
@jongpie
Bumped package version number & name
ca11b6d
@jongpie
Fixed some list views for the new queue, regenerated Apex docs
eed7153
@jongpie jongpie added Type: Bug Something isn't working Type: Enhancement New feature or request Layer: Configuration Items related to the custom hierarchy setting LoggerSettings__c or any included custom metadata type Layer: Log Management Items related to the custom objects & Logger Console app labels Sep 28, 2023
@jongpie jongpie had a problem deploying to Experience Cloud Scratch Org September 28, 2023 04:02 — with GitHub Actions Failure
@jongpie
Fixed an issue in LogEntryEventHandler with duplicate LoggerScenario_…
6d35d57 
…_c records, fixed some test issues in LogManagementDataSelector_Tests
@jongpie
Bit o' code cleanup
bd23324
@jongpie jongpie temporarily deployed to Experience Cloud Scratch Org September 30, 2023 23:10 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Base Scratch Org September 30, 2023 23:10 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Experience Cloud Scratch Org October 1, 2023 04:14 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Base Scratch Org October 1, 2023 04:14 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
...ore/main/configuration/classes/LoggerParameter.cls 100.00% <100.00%> (ø)
...in/log-management/classes/LogEntryEventHandler.cls 90.92% <100.00%> (+0.32%) ⬆️
...g-management/classes/LogManagementDataSelector.cls 100.00% <100.00%> (ø)
.../main/log-management/classes/LoggerEmailSender.cls 93.33% <100.00%> (ø)
...ain/logger-engine/classes/LogEntryEventBuilder.cls 94.57% <ø> (ø)
...-logger/core/main/logger-engine/classes/Logger.cls 96.38% <ø> (ø)

📢 Thoughts on this report? Let us know!.

@jongpie jongpie added the on hold label Oct 4, 2023
@jongpie
Copy link
Owner Author

jongpie commented Oct 4, 2023

I'm putting this on-hold for the moment - queues can't be included in managed packages, and since Nebula Logger has both an unlocked package and a managed package, the solution needs to work for both. I'll continue researching options to see what's feasible.

@jongpie jongpie removed this from the Version 4.12.0: Winter '24 Release milestone Oct 5, 2023
@jongpie
Copy link
Owner Author

jongpie commented Jul 7, 2024

After letting this PR sit open for several months, I'm going to close this, and I'm not going to release any changes for #545 at this time:

  • The approach used (including a default queue) doesn't work with managed packages, and there isn't a clear alternative approach to use right now that would "just" work out-of-the-box.
  • It also doesn't seem to be a problem any more. If/when others report this is still an issue, we can revisit figuring out how to handle it.

@jongpie jongpie closed this Jul 7, 2024
@jongpie jongpie mentioned this pull request Jul 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Layer: Configuration Items related to the custom hierarchy setting LoggerSettings__c or any included custom metadata type Layer: Log Management Items related to the custom objects & Logger Console app on hold Type: Bug Something isn't working Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors occur when new Log__c records are assigned to license types that can't own custom object records
1 participant
@jongpie