Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TP 1.0.237 does not build all supported OS #312

Closed
rgleason opened this issue May 25, 2023 · 12 comments
Closed

TP 1.0.237 does not build all supported OS #312

rgleason opened this issue May 25, 2023 · 12 comments

Comments

@rgleason
Copy link
Contributor

rgleason commented May 25, 2023 •
edited
Loading

It appears that we are missing the following metadata, from each plugin built with TP 1.0.237 Template. Many users are reporting that TP Plugins are missing and there is a study done that shows the certain OS are missing.

From the TP Template Table
For example Climatology_pi 1.5.5 + TP1.0.237 was recently built and resulted in this list of metadata:

climatology-metadata-result-list.txt

Flatpak      
flatpak-aarch64-22.08-arm64 22.08 fltpk wx32 gtk3 O58 Primary ADD <--- DOES NOT EXIST
flatpak-x86_64-22.08 22.08 fltpk wx32 gtk3 O58 Primary ADD <---- DOES EXIST
Debian 12 Bookworm   wx32 is assumed  
debian-arm64-12-bookworm Jammy* wx32 gtk3 O58 ADD <-- DOES EXIST - is the target correct?
debian-armhf-12-bookworm Jammy* wx32 gtk3 O58 ADD <-- DOES EXIST - is the target correct?
debian-x86_64-12-bookworm Jammy* wx32 gtk3 O58 ADD <---DOES EXIST - is the target correct?

More Detail

Filename (can be anything as it is not used) | Target (most important) |

climatology_pi-1.5.5.0-debian-arm64-wx32-12-bookworm-arm64.xml uses
<target>debian-wx32-arm64</target>
climatology_pi-1.5.5.0-debian-arm64-wx32-12-bookworm-arm64.xml uses
<target>debian-wx32-armhf</target>
climatology_pi-1.5.5.0-debian-x86_64-12-bookworm.xml uses
<target>debian-wx32-x86_64</target>

All three seem to have a "-wx32" in the target. Is this correct?

Also Is it possible to make the last filename have -wx32 ? Like this?

climatology_pi-1.5.5.0-debian-wx32-x86_64-12-bookworm.xml

so that it is easy to determine which files are for O5.6.2 and O5.8.2?
@rgleason
Copy link
Contributor Author

rgleason commented May 25, 2023 •
edited
Loading

Additional Information:
Radar_pi 5.5.0 a Shipdriver Template has for Debian 12 Bookworm (arm64, armhf, x86_64)
<target>debian-arm64</target>
<target>debian-armhf</target>
<target>debian-x86_64</target>

Also see old plugins Issue posting OpenCPN/plugins#804 (comment)
`

@rgleason
Copy link
Contributor Author

rgleason commented May 25, 2023 •
edited
Loading

aarch64: Debian package: No explanation to missing plugins.
#2986

This is a pretty good technique to see what plugin metadata is missing.

Also see OpenCPN/OpenCPN#2986 (reply in thread)

https://docs.google.com/spreadsheets/d/1_xQJ4gIGIp0rlexZTMdIkxrLMKKYzKQ7UzbCkGQ_IG4/htmlview

@rgleason
Copy link
Contributor Author

Trying to figure out how to build flatpak-aarch64-22.08-arm64
how does arm64 get built? where is the parameter for that?

In circleci/config.yml
add after " build-flatpak-x86-2208:"

build-flatpak-arm64-2208:
    machine:
        image: ubuntu-2004:202010-01
    environment:
    - OCPN_TARGET:  flatpak
    - FLATPAK_BRANCH: beta
    - CLOUDSMITH_PKG_EXT: gz
    - SDK_VER: 22.08
    - DEPLOY_USE_ORB: true
    steps:
    - checkout
    - run: chmod a+x ci/*.sh
    - run:
        command: bash ci/circleci-build-flatpak.sh
        no_output_timeout: 30m
    - deploy-code

and at the top of config.yml add

    - build-flatpak-arm64-2208:
        <<: *std-filters

@rgleason
Copy link
Contributor Author

rgleason commented May 27, 2023 •
edited
Loading

From Shipdriver v3.2.3 Cloudsmith shipdriver-prod LATER: Mike advised that the current shipdriver template is SD3.2.4-beta3 I have checked those metadata and they are the same as SD3.2.3

I think we can use these for the results that we need in TP Template. Then using Climatology 1.5.5.2 metadata that has been built in Cloudsmith for comparision

DEBIAN 12 BOOKWORM

ShipDriver-sd3.2.3-debian-12.xml

  <target>debian-x86_64</target>
  <target-version>12</target-version>
  <target-arch>x86_64</target-arch>

climatology_pi-1.5.5.2-debian-x86_64-12-bookworm.xml

<target>debian-x86_64</target>
<target-version>12</target-version>
<target-arch>x86_64</target-arch>

ShipDriver-sd3.2.3-debian-A32-12.xml

  <target>debian-armhf</target>
  <target-version>12</target-version>
  <target-arch>armhf</target-arch>

climatology_pi-1.5.5.2-debian-armhf-12-bookworm-armhf.xml

<target>debian-armhf</target>
<target-version>12</target-version>
<target-arch>armhf</target-arch>

ShipDriver-sd3.2.3-debian-A64-12.xml

  <target>debian-arm64</target>
  <target-version>12</target-version>
  <target-arch>arm64</target-arch>

climatology_pi-1.5.5.2-debian-arm64-12-bookworm-arm64.xml

<target>debian-arm64</target>
<target-version>12</target-version>
<target-arch>arm64</target-arch>

FLATPAK 22.08

ShipDriver-sd3.2.3-flatpak-22.08.xml

  <target>flatpak-x86_64</target>
  <target-version>22.08</target-version>
  <target-arch>x86_64</target-arch>

climatology_pi-1.5.5.2-flatpak-x86_64-22.08-flatpak.xml

<target>flatpak-x86_64</target>
<target-version>22.08</target-version>
<target-arch>x86_64</target-arch>

ShipDriver-sd3.2.3-flatpak-A64-22.08.xml

<target>flatpak-aarch64</target>
 <target-version>22.08</target-version>
 <target-arch>aarch64</target-arch>

climatology_pi-1.5.5.2-flatpak-aarch64-22.08-flatpak.xml

MISSING!!!

in climatology_pi

in circleci/config.yml
Below Line 69 & 70 add

        - build-flatpak-aarch64-2208:
            <<: *std-filters

in circleci/config.yml
below the end of "build-flatpak-x86-2208:" next line after 537 Add.

    build-flatpak-aarch64-2208:
        machine:
            image: ubuntu-2004:202010-01   <---- is this image right?
        environment:
        - OCPN_TARGET:  flatpak
        - FLATPAK_BRANCH: beta
        - CLOUDSMITH_PKG_EXT: gz
        - SDK_VER: 22.08
        - DEPLOY_USE_ORB: true
        steps:
        - checkout
        - run: chmod a+x ci/*.sh
        - run:
            command: bash ci/circleci-build-flatpak.sh
            no_output_timeout: 30m
        - deploy-code

When I look at the build for "build-flatpak-arm64:" starting at line 538

    build-flatpak-arm64:
        machine:
            image: ubuntu-2004:202101-01
        resource_class: arm.medium
        environment:
        - OCPN_TARGET:  flatpak-arm64
        - FLATPAK_BRANCH: stable
        - CLOUDSMITH_PKG_EXT: gz
        - SDK_VER: 20.08
        - DEPLOY_USE_ORB: true
        steps:
        - checkout
        - run: chmod a+x ci/*.sh
        - run:
            command: bash ci/circleci-build-flatpak.sh
        - deploy-code

Maybe this would be a better example to use, as it is using "resource_class: arm.medium" line which is more current for circleci! https://circleci.com/docs/using-arm/ If we do that, that would be changed to be

    build-flatpak-aarch64:
        machine:
            image: ubuntu-2004:202101-01
        resource_class: arm.medium
        environment:
        - OCPN_TARGET:  flatpak-aarch64
        - FLATPAK_BRANCH: stable
        - CLOUDSMITH_PKG_EXT: gz
        - SDK_VER: 22.08
        - DEPLOY_USE_ORB: true
        steps:
        - checkout
        - run: chmod a+x ci/*.sh
        - run:
            command: bash ci/circleci-build-flatpak.sh
        - deploy-code

I think maybe this last revision would the be better one to add. What do you think?
See also Circleci Selecting Resources
https://circleci.com/product/features/resource-classes/

@rgleason
Copy link
Contributor Author

I decided to add to circleci/config.yml the following:
at the top

        - build-flatpak-aarch64-2208:
            <<: *std-filters

at Line 556 with some reorganization of existing builds

    build-flatpak-aarch64-2208:
        machine:
            image: ubuntu-2004:202101-01
        resource_class: arm.medium
        environment:
        - OCPN_TARGET:  flatpak-aarch64
        - FLATPAK_BRANCH: stable
        - CLOUDSMITH_PKG_EXT: gz
        - SDK_VER: 22.08
        - DEPLOY_USE_ORB: true
        steps:
        - checkout
        - run: chmod a+x ci/*.sh
        - run:
            command: bash ci/circleci-build-flatpak.sh
        - deploy-code

I changed the Climatology version to 1.5.5.3 and commited and pushed.
the "flatpak-aarch64-2208" has successfully built.

Now how to get it tested?

@rgleason
Copy link
Contributor Author

I have asked for testing in the Cruiser Forum's Climatology thread
https://www.cruisersforum.com/forums/f134/climatology-102281.html

@bdbcat
Copy link
Contributor

bdbcat commented May 28, 2023

I will try to test today.
Take me an hour or so, since I need to build a larger sdcard image for my rPI4.
Please stand by.

@bdbcat
Copy link
Contributor

bdbcat commented May 28, 2023 •
edited
Loading

Climatology v1.5.5.3 for flatpak/aarch64 imports, loads, and runs just fine by live test.

Related note: There really is no reason at all to build flatpak 20.08. SDK 20.08 is long gone, unavailable. O58 requires SDK 22.08. So no reason to ask users to test a plugin built on 20.08.

@rgleason
Copy link
Contributor Author

rgleason commented May 28, 2023 •
edited
Loading

Great thanks Dave. Is there any reason to test the Debian 12 Bookworm, or should I just assume it works? Bram hasn't tested or advised yet.

I think I will comment out the two flatpak 2008 builds.

@rgleason rgleason mentioned this issue May 28, 2023
Open
@bdbcat
Copy link
Contributor

bdbcat commented May 28, 2023

I will try to get to debian 12 test tonight.

@rgleason
Copy link
Contributor Author

rgleason commented Jun 9, 2023

Closing. Done. Thanks!

@rgleason rgleason reopened this Jun 20, 2023
@rgleason
Copy link
Contributor Author

rgleason commented Aug 1, 2023

Later 8/1/2023 fixed Jammy.

@rgleason rgleason closed this as completed Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bdbcat @rgleason