-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is SearchFilter necessary? #161
Comments
I just came across this too. I want to omit the filter to search both But when omitting filter, e.g. resp, err := client.Search.Do(c.Request().Context(),
¬ionapi.SearchRequest{
Query: "test",
}) the API returns the error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
First of all,
thank you for the repo! I am very much enjoying it.
Currently, I am testing some workloads with Search.Do function that requires a SearchFilter.
Notion API does not require for us to specify any filter (basically omit,) but I think there must be other reasons you have enforced it not to be nil. However, the objects we retrieve from the Search.Do function do provide the ObjectType, which could hint us the type of the object, meaning that we could possibly skip the SearchFilter if that is nil.
So... if there's any chance, could I post PR with the following and the some tests:
But as always, I would like to learn the reason.
Thank you!
The text was updated successfully, but these errors were encountered: