Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live reloading (re-bundling of both app and worker bundles) not working #2

Open
jliebrand opened this issue Sep 26, 2017 · 3 comments

Comments

@jliebrand
Copy link
Contributor

First of all, thanks for reviving this, as indeed the other two modules do not seem to be maintained anymore!

But I've just tried to use this (on mac and ios), but haven't yet got it working. More annoying, there seems to be something stopping the packager from seeing updates I make.

Have you had any issues with the underlying watchman not picking edits?

@jliebrand
Copy link
Contributor Author

Correction; it seems it does spot when I make a change, because if I use the simulator I can see it reloading on edit once I enable live reload. So that part seems to be ok

However, it reloads the old bundle. So I'm assuming the bundles aren't updated. Does this mean I have to manually rebundle both the app and the worker?

@Traviskn
Copy link
Contributor

Traviskn commented Sep 27, 2017

Hi @jliebrand, thanks for checking out react-native-threads!

Unfortunately the worker thread bundle reloading doesn't work very well for me either, my personal workflow has been to restart my app in order to pick up changes.

It's definitely not ideal, I'm hoping to be able to find a way to make the development experience better. Ideally I'd like to be able to reload worker bundles and launch remote debuggers for worker threads, but I'm not quite sure right now what kind of work that would entail.

@jliebrand
Copy link
Contributor Author

Thanks for the confirmation. For me, even restarting the app didn't work... but I just restarted everything (xcode, packager, simulator), and now it works as you describe.

I'll update the title of this bug, and leave it open in case you do work out how to get live reloading working

@jliebrand jliebrand changed the title Packager doesn't spot updates? Live reloading (re-bundling of both app and worker bundles) not working Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants