-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate some widgets with painter #79
Conversation
Hey @payam-zahedi Nice work. I appreciate the fact you did this anyway, real good. Pending from our conversation on #55, it became obvious we would have to remove the I played with a quick approach last weekend using a Another might be to make a v5 release without the itemBuilder but keep the v4 maintained as well. What do you think as well. cc @ened @CaiJingLong @aagarwal1012 |
In our project we are not using itemBuilder, however - others might.
.. and pass that as a function to the SpinKit APIs? The Function could even take an optional parameter for the time or animation progress, so that the painting & animation are dynamic? WDYT @payam-zahedi ? |
Thanks @ened, that indeed solves the issue of modifying the kit from the outside. I love the approach I do hope the users already comfortable with composing widgets would not see the canvas as an added level of complexity. I would indeed love to do this way. 😅 |
@ened thanks for this great approach, but I think we have limitation for it. this approach is very nice when we will paint a kit with a single widget(painter) like spinning-circle. but what happened if we want to paint kit with multiple widgets(painters) like Wake. |
Yes @payam-zahedi it did cross my mind in order to maintain "parity" in some way the index would be necessary indeed. |
ok @jogboms, should I change my PR? |
Hi I just widgets some files and integrated them with CustomPainter. List of widgets that have been Changed:
also, I Removed itemBuilder of these widgets.
If any changes needed please let me know. Thank you