Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test cases #9

Open
15 of 17 tasks
juliakreutzer opened this issue Dec 6, 2018 · 2 comments
Open
15 of 17 tasks

Test cases #9

juliakreutzer opened this issue Dec 6, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@juliakreutzer
Copy link
Collaborator

juliakreutzer commented Dec 6, 2018 •
edited by may-

We need to include tests (urgently)! Most important:

  • unit tests for all modules
    • encoder
    • embeddings
    • decoder
    • attention
    • data creation
    • batch creation
    • data iterators
    • beam search
      • alpha values
    • greedy decoding
  • tiny benchmarks for quality checks
  • style checks, e.g. with pylint & pep8
  • shape checks for
    • encoder input
    • decoder input
    • attention

We can take inspiration from the tests in Sockeye, OpenNMT, or Neuralmonkey or any other NMT toolkit.
@joeynmt joeynmt added the enhancement New feature or request label Mar 7, 2019
@juliakreutzer
Copy link
Collaborator Author

search tests in #72

juliakreutzer added a commit to juliakreutzer/bandit-joeynmt that referenced this issue Jan 23, 2020
@juliakreutzer
Merge pull request joeynmt#9 from heidelkin/convert_reward_for_bpe
1e834fd 
add: make token_reward->bpe_reward
@may-
Copy link
Collaborator

may- commented Apr 10, 2021

unit test for nbest predictions #146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@juliakreutzer @may- @joeynmt