-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalizing URL path: Replace #val with custom values/attributes #96
Comments
Formally right solution: It will not work with the array of regex, because those replacements are matched against individual chunks. In your example if the path is:
Actually right solution: don't customize anything. You're missing the point of this library. It's meant to work with an unknown paths and provide good results. So that when you add a new API tomorrow |
Current values using the 'express-prom-bundle' module:
attribute: path
Value:
"/api/v1/engagements/#val/features"
"/api/v1/engagements/#val"
"/api/v1/engagements/#val/data/workspace/assets/#val/unzip"
But we are expecting the metrics report to come up with the below values:
attribute: path
Value:
"/api/v1/engagements/{engagementId}/features"
"/api/v1/engagements/{engagementId"
"/api/v1/engagements/{engagementId}/data/workspace/assets/{assetId}/unzip"
I already tried the below normalizePath expressions:
normalizePath: [
['^/api/v1/engagements/./features', '/api/v1/engagements/{engagementId}/features'],
['^/api/v1/engagements/.', '/api/v1/engagements/{engagementId}'],
]
The text was updated successfully, but these errors were encountered: