New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompactible with Typescript 4.5.x #158
Comments
valentinpalkovic
added a commit
to valentinpalkovic/flowgen
that referenced
this issue
Jan 6, 2022
Like described in joarwilk#158 flowgen currently doesn't support Typescript 4.5.x versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With Typescript 4.5.x some types are generated differently:
Source:
Generated output with Typescript 4.4.5:
Generated output with Typescript 4.5.4:
Changes:
Debugging:
Depending on which package manager you use, it can happen that it "tricks" you. I wanted to upgrade Typescript and try different versions out, but I recognized, that sometimes a Typescript folder will be placed into
./node_modules/flowgen/node_modules
. Its version doesn't reflect necessarily the version of Typescript you have defined in the package.json. Indeed, if a clean install happens without having a yarn.lock file, yarn doesn't nest a different Typescript version in the flowgen folder. Or just delete it manually to be sure to always use the Typescript folder in the root node_modules folder. The Flowgen package itself doesn't define a fixed Typescript version and allows everything from 4.0.0 until < 5.0.0.I will try to debug the issue and provide a MR in the next days, if I find some time for it! :)
The text was updated successfully, but these errors were encountered: