Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

474 #485

Merged
merged 5 commits into from
Oct 6, 2021
Merged

474 #485

merged 5 commits into from
Oct 6, 2021

Conversation

albertotn
Copy link
Contributor

I've followed this steps while working on #474 :

  • update my fork
  • clone the repository
  • install java 16 ( from https://adoptopenjdk.net/ )
  • installed last release of eclipse: 2021-09 (4.21.0)
  • change version of java from 1.8 to 16
  • fixed a test not working in my locale
  • removed one unused import

All test are passed, so I think cron-utils is ready for Java 16, there are some other test I need to do ?

@jmrozanec jmrozanec merged commit 5321c76 into jmrozanec:master Oct 6, 2021
@jmrozanec
Copy link
Owner

@albertotn should be ok 😄 Thanks! We just merged!

@albertotn
Copy link
Contributor Author

Great! Can you label this PR to hacktoberfest-accepted ?

@jmrozanec jmrozanec added this to the next milestone Oct 6, 2021
@jmrozanec
Copy link
Owner

@albertotn done!

@albertotn
Copy link
Contributor Author

Thanks, if you want open a new issue for java 17 and assign to me, os I will check asap too

@jmrozanec
Copy link
Owner

@albertotn deal 😄 Here the new issue: #486

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@albertotn albertotn

Labels
hacktoberfest-accepted
Projects
None yet
Milestone
9.1.7
Development

Successfully merging this pull request may close these issues.
2 participants
@albertotn @jmrozanec