-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helix not STEP converted correctly #72
Comments
The fix should be something along these lines:
but I am not sure why this breaks demo-status-0.6.ipt. I didn't have too much time today to look at. |
My suspicions were confirmed by switching to another library, as I knew the aforementioned calculations were correct. steps_U = Helix.calcSteps(min_U, max_U, (max_U - min_U) / (2 * pi) * 4) cannot be fixed, at least the U, but must depend on the 'pitch' length, as you call it (isn't pitch an angle?). But with a 'big' number my helix was OK, whilst your demo-status-0.6.ipt failed. UPDATED: |
If you create a plain helix with Fusion360, such as this one:
its STEP converted version looks like this:
ShareCAD
![image](https://private-user-images.githubusercontent.com/85944755/243965640-a36cf8d9-2a22-4d2d-9da6-df6b7f4c4f67.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg0MjE3NzQsIm5iZiI6MTcxODQyMTQ3NCwicGF0aCI6Ii84NTk0NDc1NS8yNDM5NjU2NDAtYTM2Y2Y4ZDktMmEyMi00ZDJkLTlkYTYtZGY2YjdmNGM0ZjY3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjE1VDAzMTc1NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWIyNDUxODI3NDMwN2RkODAxOTI4YTI4ZWUxMTg2ZGEyMTEyODZjNDRjN2QyMDliZDk3ZGQ3MmMxYmEyMTc1ZDgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.XJ01DWFKDJmuTc1uqZCVn-RdBICxbv1WIEdWElkl3hY)
Autodesk viewer
![image](https://private-user-images.githubusercontent.com/85944755/243965905-c0c511ac-349c-4abc-a87a-17b835f8ee0c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg0MjE3NzQsIm5iZiI6MTcxODQyMTQ3NCwicGF0aCI6Ii84NTk0NDc1NS8yNDM5NjU5MDUtYzBjNTExYWMtMzQ5Yy00YWJjLWE4N2EtMTdiODM1ZjhlZTBjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjE1VDAzMTc1NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTc0ZGFlNDBjNzczNTY0ODIxMzA1NjQ0NDQyZmZkYzAwNWJlODQxOTc4YjNjZWU0ZjAzMzUxNzUzN2NiZTM3YTMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.AbnRXEQvTeKJYxrbLw8AQVP0DnYhCnyZZzGJNJOiymQ)
helix_plain.zip
The text was updated successfully, but these errors were encountered: