Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dxfgrabber obsolete #49

Open
marcocecchiscmgroup opened this issue Aug 30, 2021 · 6 comments
Open

Dxfgrabber obsolete #49

marcocecchiscmgroup opened this issue Aug 30, 2021 · 6 comments
Assignees
Labels
enhancement Fixed Issue is fixed

Comments

@marcocecchiscmgroup
Copy link

Hello Jens,
as you might remember, we had an exchange about a bunch of new features that I was suggesting in your InventorLoader project a few years ago. I've seen that you made more progress with it and that sounds great. The support for F3D is very appreciated in this respect.
I did a sync lately, so as to update my own project, and I have noticed that you now include dxfgrabber to allow 3d import from dxf, exactly as we discussed at that time. I just wanted to let you know, if you are ok with it, that dxfgrabber is obsolete and does not support entities such as all the four surfaces (revolved, swept, ...), that are as well of type BODY. You should refer to ezdxf, instead, lest supporting only a tiny subset of all the 3D entities.
From the doc: "ezdxf is also a replacement for my dxfwrite and my dxfgrabber packages but with different APIs [...] Since ezdxf can do all the things that dxfwrite and dxfgrabber can do, I focused on the development of ezdxf, dxfwrite
and dxfgrabber are in maintenance mode only and will not get any new features, just bugfixes."

Keep up with the good work buddy!

@jmplonka
Copy link
Owner

Thank you for the gentle reminder that I have to replace the dxfgrabber with ezdxf.
Hope I'll find some time to do the replacement. ;)

@marcocecchiscmgroup
Copy link
Author

Kudos again for the latest features, such as support to Fusion 360.
I can help, in case.

@marcocecchiscmgroup
Copy link
Author

Integrating ezdxf is one line of code and will allow to import the four kind of surfaces that are foreseen in the dxf format.: LOFTED, SWEPT, EXTRUDED and REVOLVED.

@luzpaz
Copy link
Contributor

luzpaz commented Apr 28, 2023

@jmplonka looks like we need to add ezdxf to package.xml (it's not mentioned in there)

<depend>Part</depend>
<depend>Draft</depend>
<depend>Sketcher</depend>
<depend>SheetMetal Workbench</depend>
<depend>olefile</depend>
<depend>xlrd</depend>
<depend>xlwt</depend>
<depend>xlutils</depend>

@jmplonka
Copy link
Owner

done.

@jmplonka
Copy link
Owner

By replacing dxfgrabber by ezdxf other "bodies" can now also be imported.

@jmplonka jmplonka self-assigned this Apr 29, 2023
@jmplonka jmplonka added enhancement Fixed Issue is fixed labels Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Fixed Issue is fixed
Projects
None yet
Development

No branches or pull requests

3 participants