Description
Hi there,
looking into Camunda.Api.Client we see that there are only two tests - and they are failing right now (at least we cannot get them to work in the master branch). We also see, that many class definitions are within other classes files, sometimes even within other classes - not sure, if that was indeed done on purpose or just out of convenience, but it makes it very hard to actually find some of the classes ...
So we have thought about a refactoring of the project and redoing the tests - and adding tests whenever we have the time. Also we think about introducing just enough interface-definitions to be able to unit test user code rather easily instead of using wrapper interfaces and classes in order to do so.
A first starting point for a discussion can be found here:
https://github.com/gaensebluemchenritter/Camunda.Api.Client/tree/Refactoring
Both tests are working right now and restructuring as well as pulling out embedded classes is done. Additional interface-definitions are still missing, however ...
Disclaimer: this is not meant as criticism, but we strongly believe that restructuring and refactoring the code will help in the future, making it easier to actually apply changes, enhancements, bugfixes, ... this also is naught but a starting point for a discussion, if this would indeed be helpful and if the structure is valid and self-explanatory enough. If there is no intention of thinking about stuff like that, it is ok - I just thought it could be interesting enough to talk about it.