Not sending correct grade because the last-grade is seen as the current-grade

[SAHellauer]

Please review the following line:

moodle-local_ltiprovider/lib.php

Line 360 in e70e4b9

if ( intval($grade) == $user->lastgrade ) {

Should the above code be an exact check and then we store the exact grade being sent in the db?

Use Case

1. A quiz is worth 10 points.
2. Student gets a 9.2 on their first attempt.
3. Cron script runs, sends the float value and then sets the last-grade to 9 in the db.
4. Student gets a 9.8 on their second attempt.
5. Cron script runs and does not send the float value, because the check in the code referenced above considers 9.2 and 9.8 as the same.

Or at the very least could we round the grade and check that way?

$roundedGrade = round($grade);

if (intval($roundedGrade) == $user->lastgrade) {
    continue;
}

And then store the rounded grade instead.

$DB->set_field('local_ltiprovider_user', 'lastgrade', intval($roundedGrade), array('id' => $user->id));

This solution still does not provide an exact check. 9.2 and 9.3 would still be see as 9. But I believe it would be a little more accurate.

[SAHellauer]

You could also use $grade->dategraded and not check/store lastgrade at all.

https://github.com/jleyva/moodle-local_ltiprovider/compare/MOODLE_29_STABLE...SAHellauer:grade_sync?expand=1

[jleyva]

Hi, yes, you are right. This is something that has been there since the beginning and I totally forget about it.
I suppose this happened because I was considering that Moodle only returns grades from 0 to 100 so I created the lastgrade field as int, but that's not true so this needs addressing in someway (ideally changing the field type and checks)