Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream mkBabashka? #72

Open
sg-qwt opened this issue Jul 20, 2023 · 1 comment
Open

Upstream mkBabashka? #72

sg-qwt opened this issue Jul 20, 2023 · 1 comment
Labels

Comments

@sg-qwt
Copy link

sg-qwt commented Jul 20, 2023

Hi Jose,

Thanks for the great work. Babashka has only a fixed number of feature flags.

Wondering if it's possible to upstream the work of mkBabashka to nixpkgs, so that consume babashka.override { withExtraFeatures = [ "jdbc"] } from nixpkgs would be easy without this flake?

Best

@jlesquembre
Copy link
Owner

I'd like to upstream clj-nix, or parts of it, to nixpkgs. I like the poetry2nix approach: https://github.com/NixOS/nixpkgs/tree/b373c3322762d14e5aa0cedd18877047e3c3f7f4/pkgs/development/tools/poetry2nix/poetry2nix

mkBabashka depends on functionality provided by clj-nix, like the locker file generator or the helpers to generate uberjars. We need to upstream those too, but unfortunately, I think clj-nix needs to be more mature before it can be upstreamed to nixpkgs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants