Skip to content

Commit 5774f70

Browse files
committed
refactoring
1 parent c976069 commit 5774f70

File tree

4 files changed

+18
-5
lines changed

4 files changed

+18
-5
lines changed

doc/examples/scripts/ipc-wal-demo.venice

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,13 @@
2121

2222
;;;; IPC Write-Ahead-Log demo
2323

24-
(let [wal-dir (io/file (io/temp-dir "wal-"))]
24+
(let [srv-dir (io/file (io/temp-dir "srv-"))
25+
wal-dir (io/file (io/temp-dir "wal-"))]
2526
(try
2627
;; start client/server with Write-Ahead-Log and offer a few messages
2728
(println "Starting server/client ...")
2829
(try-with [server (ipc/server 33333
30+
:server-log-dir srv-dir
2931
:write-ahead-log-dir wal-dir
3032
:write-ahead-log-compress true
3133
:write-ahead-log-compact true)
@@ -53,6 +55,7 @@
5355
;; the new server will read the Write-Ahead-Logs and populate the queue :testq
5456
(println "Restarting server/client ...")
5557
(try-with [server (ipc/server 33333
58+
:server-log-dir srv-dir
5659
:write-ahead-log-dir wal-dir
5760
:write-ahead-log-compress true
5861
:write-ahead-log-compact true)
@@ -79,6 +82,8 @@
7982

8083
(sleep 100)
8184

82-
(finally (io/delete-file-tree wal-dir)))
85+
(finally
86+
(io/delete-file-tree srv-dir)
87+
(io/delete-file-tree wal-dir)))
8388

8489
(println "Done."))

doc/examples/scripts/ipc-wal-load-demo.venice

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,16 @@
2121

2222
;;;; IPC Write-Ahead-Log load demo
2323

24-
(let [wal-dir (io/file (io/temp-dir "wal-"))
24+
(let [srv-dir (io/file (io/temp-dir "srv-"))
25+
wal-dir (io/file (io/temp-dir "wal-"))
2526
total-msgs 100_000
2627
half-msgs (/ total-msgs 2)
2728
queue-capacity 1_000_000] ;; capacity must be big enough
2829
(try
2930
;; start client/server with Write-Ahead-Log and offer a few messages
3031
(println "Starting server/client ...")
3132
(try-with [server (ipc/server 33333
33+
:server-log-dir srv-dir
3234
:write-ahead-log-dir wal-dir
3335
:write-ahead-log-compress true
3436
:write-ahead-log-compact true)
@@ -62,6 +64,7 @@
6264
;; the new server will read the Write-Ahead-Logs and populate the queue :testq
6365
(println "Restarting server/client ...")
6466
(try-with [server (ipc/server 33333
67+
:server-log-dir srv-dir
6568
:write-ahead-log-dir wal-dir
6669
:write-ahead-log-compress true
6770
:write-ahead-log-compact true)
@@ -84,6 +87,8 @@
8487

8588
(sleep 100)
8689

87-
(finally (io/delete-file-tree wal-dir)))
90+
(finally
91+
(io/delete-file-tree srv-dir)
92+
(io/delete-file-tree wal-dir)))
8893

8994
(println "Done."))

src/main/java/com/github/jlangch/venice/impl/functions/IPCFunctions.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ public VncVal apply(final VncList args) {
190190
final File serverLogDir = serverLogDirVal == Nil
191191
? null
192192
: IOFunctions.convertToFile(
193-
walDirVal,
193+
serverLogDirVal,
194194
"Function 'ipc/server' arg ':server-log-dir' must be an `io/file`");
195195

196196
if (serverLogDir != null && !serverLogDir.isDirectory() && !serverLogDir.canWrite()) {

src/main/java/com/github/jlangch/venice/util/ipc/impl/wal/WalQueueManager.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,9 +98,12 @@ public Map<String, IpcQueue<Message>> preloadQueues()
9898

9999
for(File logFile : listLogFiles()) {
100100
if (compactAtStart) {
101+
logger.info(logFile, "WalQueueManager@preloadQueues: compacting WAL");
101102
WriteAheadLog.compact(logFile, true, true);
102103
}
103104

105+
logger.info(logFile, "WalQueueManager@preloadQueues: create queue from WAL");
106+
104107
final IpcQueue<Message> queue = DurableBoundedQueue.createFromWal(logFile, logger);
105108
queues.put(queue.name(), queue);
106109
};

0 commit comments

Comments
 (0)