refactoring

Author: jlangch

src/main/java/com/github/jlangch/venice/util/ipc/TcpClient.java

@@ -189,7 +189,7 @@ public void open() {
                         ex);
             }
 
-            // request config from server
+            // request the config from server
             try {
                 final IMessage response = send(createConfigRequestMessage());
                 if (response.getResponseStatus() != ResponseStatus.OK) {
@@ -204,20 +204,20 @@ public void open() {
                     Coerce.toVncLong(
                         config.get(
                             new VncKeyword("max-msg-size"),
-                            new VncLong(MESSAGE_LIMIT_MAX))).toJavaLong());
+                            new VncLong(Message.MESSAGE_LIMIT_MAX))).toJavaLong());
                 compressor.set(
                     new Compressor(
                         Coerce.toVncLong(
                             config.get(
                                 new VncKeyword("compress-cutoff-size"),
-                                new VncLong(MESSAGE_LIMIT_MAX))).toJavaLong()));
+                                new VncLong(-1))).toJavaLong()));
                 encrypt.set(
                     encrypt.get()             // client side encrypt request
                     || VncBoolean.isTrue(     // server side encrypt request
                         config.get(
                             new VncKeyword(":encrypt"),
-	                        VncBoolean.False)));
-        }
+                            VncBoolean.False)));
+            }
             catch(Exception ex) {
                 IO.safeClose(ch);
                 opened.set(false);
@@ -1197,9 +1197,6 @@ private static byte[] toBytes(final String s, final String charset) {
     }
 
 
-    public static final long MESSAGE_LIMIT_MIN = 2 * 1024;
-    public static final long MESSAGE_LIMIT_MAX = 200 * 1024 * 1024;
-
     private final Semaphore sendSemaphore = new Semaphore(1);
 
     private final String host;
@@ -1208,7 +1205,7 @@ private static byte[] toBytes(final String s, final String charset) {
     private final AtomicBoolean opened = new AtomicBoolean(false);
     private final AtomicReference<SocketChannel> channel = new AtomicReference<>();
     private final AtomicBoolean subscription = new AtomicBoolean(false);
-    private final AtomicLong maxMessageSize = new AtomicLong(MESSAGE_LIMIT_MAX);
+    private final AtomicLong maxMessageSize = new AtomicLong(Message.MESSAGE_LIMIT_MAX);
     private final AtomicLong messageSentCount = new AtomicLong(0L);
     private final AtomicLong messageReceiveCount = new AtomicLong(0L);
 

src/main/java/com/github/jlangch/venice/util/ipc/TcpServer.java

@@ -158,7 +158,9 @@ public long getCompressCutoffSize() {
      * @return this server
      */
     public TcpServer setMaxMessageSize(final long maxSize) {
-        maxMessageSize.set(Math.max(MESSAGE_LIMIT_MIN, Math.min(MESSAGE_LIMIT_MAX, maxSize)));
+        maxMessageSize.set(Math.max(
+                            Message.MESSAGE_LIMIT_MIN,
+                            Math.min(Message.MESSAGE_LIMIT_MAX, maxSize)));
         return this;
     }
 
@@ -560,8 +562,6 @@ private static byte[] toBytes(final String s, final String charset) {
 
 
 
-    public static final long MESSAGE_LIMIT_MIN = 2 * 1024;
-    public static final long MESSAGE_LIMIT_MAX = 200 * 1024 * 1024;
     public static final long QUEUES_MIN = 201;
     public static final long QUEUES_MAX = 20;
 
@@ -570,7 +570,7 @@ private static byte[] toBytes(final String s, final String charset) {
     private final String endpointId;
     private final AtomicBoolean started = new AtomicBoolean(false);
     private final AtomicReference<ServerSocketChannel> server = new AtomicReference<>();
-    private final AtomicLong maxMessageSize = new AtomicLong(MESSAGE_LIMIT_MAX);
+    private final AtomicLong maxMessageSize = new AtomicLong(Message.MESSAGE_LIMIT_MAX);
     private final AtomicLong maxQueues = new AtomicLong(QUEUES_MAX);
     private final AtomicBoolean encrypt = new AtomicBoolean(false);
     private final AtomicLong connectionId = new AtomicLong(0);

src/main/java/com/github/jlangch/venice/util/ipc/impl/Message.java

@@ -542,6 +542,10 @@ public static void validateQueueName(final String name) {
     }
 
 
+
+    public static final long MESSAGE_LIMIT_MIN = 2 * 1024;
+    public static final long MESSAGE_LIMIT_MAX = 200 * 1024 * 1024;
+
     public static final long EXPIRES_NEVER = -1L;
     public static final long NO_TIMEOUT = -1L;
     public static final long DEFAULT_TIMEOUT = 300L;  // 300ms

src/test/java/com/github/jlangch/venice/util/ipc/TcpClientRuntimeConfigTest.java

@@ -25,6 +25,8 @@
 
 import org.junit.jupiter.api.Test;
 
+import com.github.jlangch.venice.util.ipc.impl.Message;
+
 
 public class TcpClientRuntimeConfigTest {
 
@@ -43,7 +45,7 @@ public void test_client_defaults() throws Exception {
         try {
             assertEquals(false, client.isEncrypted());
             assertEquals(-1, client.getCompressCutoffSize());
-            assertEquals(TcpServer.MESSAGE_LIMIT_MAX, client.getMaxMessageSize());
+            assertEquals(Message.MESSAGE_LIMIT_MAX, client.getMaxMessageSize());
         }
         catch(Exception ex) {
             // OK